Skip to content

feat: add generate from latest tag #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

pocesar
Copy link

@pocesar pocesar commented Jul 10, 2023

This allows DETACHED HEAD tags to properly generate the RELEASE notes.
Otherwise it will always try to generate the full release notes from multiple tags

@pocesar pocesar force-pushed the feat/add-generateReleaseNotes branch 4 times, most recently from bbaeef1 to b32d267 Compare July 11, 2023 00:09
@pocesar pocesar force-pushed the feat/add-generateReleaseNotes branch from b32d267 to 4a08b31 Compare July 11, 2023 00:13
@ovy9086
Copy link

ovy9086 commented Jul 17, 2023

this looks good, and would love this feature 👀

@sparadiso
Copy link

Is there a voting mechanism here? 👍 would also love this feature.

@ovy9086
Copy link

ovy9086 commented Jul 19, 2023

for now I've ended up using https://github.com/mikepenz/release-changelog-builder-action to generate the proper changelogs. it's a really nice action.

this is how my steps looks like if somebody just wants to copy paste it and don't spend too much time on it 😂

jobs:
    deploy:
        name: Create release

        runs-on: ubuntu-latest

        permissions:
            contents: write
            deployments: write
            pull-requests: read

        steps:
            - name: 'Build Changelog'
              id: build_changelog
              uses: mikepenz/release-changelog-builder-action@v4
              with:
                  token: '${{ github.token }}'

            - name: Create GitHub release
              uses: softprops/action-gh-release@v1
              with:
                  body: ${{steps.build_changelog.outputs.changelog}}

nat-goodspeed added a commit to secondlife-3p/action-gh-release that referenced this pull request Feb 26, 2024
…tion-gh-release into feat/add-generateReleaseNotes

Adopt the addition of `previous_tag` input from softprops#372 .
bennettgoble added a commit to secondlife-3p/action-gh-release that referenced this pull request Feb 28, 2024
@caquino
Copy link

caquino commented Mar 25, 2024

@softprops is this a feature that you intend to add? As there is a considerable amount of 👍 on the issue for this feature I'm curious if we should wait or to find a workaround.

@chenrui333
Copy link
Collaborator

@pocesar can you fix the merge conflict for the PR, I can include this feature for the next release.

@fdventura
Copy link

@softprops could we get this merged, since it appears to bring great value to all users with little to none added effort? 🙏🏼

@chenrui333
Copy link
Collaborator

@fdventura there is merge conflict needs to be addressed first.

@melyux
Copy link

melyux commented Dec 24, 2024

Paging @pocesar

@pocesar
Copy link
Author

pocesar commented Dec 24, 2024

my PR is 81 commits behind main, maybe it won't be a simple rebase 😬

@jbrazio
Copy link

jbrazio commented Jan 21, 2025

@pocesar any follow-up ? 🚀

@louwers
Copy link

louwers commented Mar 14, 2025

This would be great for us since we use a monorepo with many different types of releases.

Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
… into feat/add-generateReleaseNotes

Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
Copy link
Collaborator

I think this PR is ready for merge, can someone on this thread test out this commit, 898f81b and see if it works for you? Thanks!

Signed-off-by: Rui Chen <rui@chenrui.dev>
… into feat/add-generateReleaseNotes

Signed-off-by: Rui Chen <rui@chenrui.dev>
… into feat/add-generateReleaseNotes

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
Copy link
Collaborator

I think this PR is ready for merge, can someone on this thread test out this commit, 898f81b and see if it works for you? Thanks!

4577bf1 is the latest commit

@chenrui333
Copy link
Collaborator

(note to myself, need to redo the latest merge master commit again)

@bencoveney
Copy link

bencoveney commented Jun 19, 2025

I have tested with commit 4577br1 and see the following:

Configuration from logs:

2025-06-19T11:32:36.8599120Z with:
2025-06-19T11:32:36.8599333Z   name: Staging 2025_06_19-11_32_36
2025-06-19T11:32:36.8599592Z   tag_name: stage-2025_06_19-11_32_36
2025-06-19T11:32:36.8609231Z   previous_tag: prod-25_06_03-13_24_55
2025-06-19T11:32:36.8609791Z   target_commitish: fccd17df11497b54721dd7922b2806da18c40ca7
2025-06-19T11:32:36.8610191Z   generate_release_notes: true
2025-06-19T11:32:36.8610620Z   prerelease: true
2025-06-19T11:32:36.8610860Z   make_latest: false
2025-06-19T11:32:36.8611087Z   overwrite_files: true
2025-06-19T11:32:36.8611639Z   token: ***

I would expect the release notes to be generated for this release, similar to how they are generated through the UI (e.g. they begin with ## What's Changed\n* ).

Instead, on the release notes of the release, I see:

stage-2025_06_19-11_32_36

Merge pull request #554 from [pull request name removed]…

(This is the full content, 3 lines ending with )

When I generate the release notes for an equivalent release from github UI, they generate correctly (e.g. they begin with ## What's Changed\n* ). The Github UI is sending the following request to build them:

https://github.com/[org]/[repository]/releases/notes?commitish=fccd17df11497b54721dd7922b2806da18c40ca7^&tag_name=stage-2025_06_19-11_32_36^&previous_tag_name=prod-25_06_03-13_24_55

I do not have a release.yml file, but I don't think that's required for generation to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants